Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Spell check, 80-char lint rule, and .gitignore file names addition #127

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

agoza
Copy link
Contributor

@agoza agoza commented Jun 12, 2022

Thank you for agreeing to review my first pull request.

It's not much work but it's good practice for me.

Closes #126

agoza added 3 commits June 11, 2022 21:46
Welcome aboard or welcome on board are both good alternatives here.
Moved a line of code a step backwards and separated a comment into two lines.
Files and file extensions generated by OS, databases, and others that GitHub will never use. Run `$git rm --cached` command if any of these file types was committed previously.
@iqfareez
Copy link
Member

BB-8 Thumbs Up

Thank you for your effort to improve this project. I love it. Merging now.

TIL. All this time I thought the word is abroad. 🤭 Glad you corrected it. 👍

@iqfareez iqfareez merged commit fbe3741 into mptwaktusolat:master Jun 13, 2022
@iqfareez
Copy link
Member

iqfareez commented Nov 1, 2022

@all-contributors add @agoza for code

@allcontributors
Copy link
Contributor

@iqfareez

We had trouble processing your request. Please try again later.

@iqfareez
Copy link
Member

iqfareez commented Nov 1, 2022

Retrying. @all-contributors add @agoza for code

@allcontributors
Copy link
Contributor

@iqfareez

I've put up a pull request to add @agoza! 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does this project accept pull requests?
2 participants