Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(type): fix push properties types #1359

Merged
merged 1 commit into from
Dec 13, 2021
Merged

fix(type): fix push properties types #1359

merged 1 commit into from
Dec 13, 2021

Conversation

oceanlvr
Copy link
Contributor

@oceanlvr oceanlvr commented Nov 22, 2021 •
edited
Loading

Type signatures and implementations are inconsistent.

topicAlias should be number type, and payloadFormatIndicator should be boolean type.

relative resource:

@oceanlvr
Copy link
Contributor Author

@YoDaMa Please take a look THANKS!

@oceanlvr oceanlvr mentioned this pull request Nov 22, 2021
Merged
2 tasks
@YoDaMa
Copy link
Contributor

YoDaMa commented Dec 13, 2021

@oceanlvr thanks for the PR. lgtm.

@YoDaMa YoDaMa merged commit cb6bdcb into mqttjs:master Dec 13, 2021
@oceanlvr oceanlvr deleted the fix_push_props_type branch December 13, 2021 14:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oceanlvr @YoDaMa