mqtt-packet side of fix for MQTTjs issue 235 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
added a commit
that referenced
this pull request
Jan 18, 2015
mqtt-packet side of fix for MQTTjs issue 235
|
This is perfect! Would you like to help maintaining this module? I think there might be some more issues like this one! |
|
I updated it to use booleans vs integers. |
|
Hi, Sure, I would be happy to help maintaining this module any way that I can. Thanks! On Sun, Jan 18, 2015 at 8:42 AM, Matteo Collina notifications@github.com
|
|
Added you to the mqtt-packet team! :). Please feel free to review all the parsing and send PRs according to CONTRIBUTING.md :). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ,
Here are some proposed changes to add the session present bit support. Thank you in advance for checking it out and letting me know what you think.