Fix Buffer Out of Bounds Error #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teDefaults() to allow just the parsing to be performed on its own.
This was referenced Feb 9, 2021
Merged
mcollina
requested changes
Feb 9, 2021
…nerate the mqtt bytes, and then parse that buffer to a full packet object with defaults shown. Add an additional testParseAndGenerate function which takes a packet and an mqtt bytes and tests they Parse and Generate in both directions.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in _parseVarByteNum() function causing Buffer Out of Bounds Error.
Added Tests.
Also refactored the testParseGenerateDefaults() test function to separate out a new testParseOnly() which can be used directly.
Fixes #99, fixes #98, closes #78, fixes mqttjs/MQTT.js#1073, fixes mqttjs/MQTT.js#993, fixes mqttjs/MQTT.js#1176
Possible fix to mqttjs/MQTT.js#1228 which has this function in the call stack. Unfortunately no specific test provided in that issue to prove it's fixed.
Probable fix to #72, but gist and test not longer present to check it.