Add support for mosquitto bridge versions 131 and 132 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure it's clear that I don't have write access, so somebody will have to merge this if it's okay. |
robertsLando
added a commit
to moscajs/aedes
that referenced
this pull request
Mar 4, 2021
* feat(bridge): Support incoming mosquitto bridge connections The incoming mosquitto bridge connections add 128 to the protocol version to indicate ras=true and nl=true. Support for this was added in mqtt-packet with mqttjs/mqtt-packet#106 Subscriptions from these connections will have ras=true and nl=true When publishing to these connections, aedes will now copy the Packet and set retain to false only if ras is not true. * clarify that Bridge Protocol is supported only for incoming connections * Respond to some code review comments * Move the retain flag clearing into the publish function This allows all callers of subscribe to receive the retain flag set to false unless explicitly requested by passing rap=true * Revert previous behaviour change and adjust test Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These protocols are for bridge mode of version 3. According to https://github.com/mqtt/mqtt.org/wiki/bridge_protocol these versions set the following properties: