Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

convert to ES6 classes and cleanup dependencies #87

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

seriousme
Copy link
Contributor

I converted the function objects to ES6 classes and cleaned up unused dependencies.
As "safe-buffer" is deprecated I have removed it as well.

As to benchmarks: results of local testing below

  Time in seconds    
Node version no-classes using classes Difference
6 7,2 7,46 3,61%
8 6,11 6,46 5,73%
10 4,69 4,88 4,05%
12 4,87 4,85 -0,41%
14 4,84 4,91 1,45%

Kind regards,
Hans

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 81d401b into mqttjs:master Aug 26, 2020
@seriousme seriousme deleted the es6-classes branch August 26, 2020 07:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants