Skip to content

Global: Move some WebGPU modules from core to addons. #29511

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Sep 27, 2024

Fixed #29505.

Description

As suggested in #29505 this PR moves some WebGPU modules from core to addons.

@Mugen87 Mugen87 added this to the r170 milestone Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 687.46
170.22
687.46
170.22
-3 B
-1 B
WebGPU 805.13
216.73
805.13
216.74
-3 B
+3 B
WebGPU Nodes 804.64
216.6
804.63
216.59
-3 B
-3 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 463.24
111.86
463.24
111.86
-3 B
-1 B
WebGPU 534.87
144.3
534.85
144.34
-17 B
+35 B
WebGPU Nodes 491.21
134.05
491.2
134.09
-17 B
+31 B

@Mugen87 Mugen87 merged commit cd250e2 into mrdoob:dev Sep 27, 2024
10 of 11 checks passed
@@ -153,6 +153,7 @@ const exceptionList = [
'webgpu_tsl_vfx_linkedparticles',
'webgpu_tsl_vfx_tornado',
'webgpu_textures_anisotropy',
'webgpu_backdrop_water',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webgpu_backdrop_water seems to have some timing issues. When updating related code, the example tends to fail although nothing changes at the visuals. Adding it to the exception list for now.

@sunag sunag mentioned this pull request Sep 28, 2024
@mrdoob
Copy link
Owner

mrdoob commented Oct 3, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 687.46
170.22
687.46
170.22
-3 B
-1 B
WebGPU 805.13
216.73
805.13
216.74
-3 B
+3 B
WebGPU Nodes 804.64
216.6
804.63
216.59
-3 B
-3 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 463.24
111.86
463.24
111.86
-3 B
-1 B
WebGPU 534.87
144.3
534.85
144.34
-17 B
+35 B
WebGPU Nodes 491.21
134.05
491.2
134.09
-17 B
+31 B

I wonder why file sizes didn't get smaller... 🤔

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some WebGPU modules from core to addons.
2 participants