feat(arena): various improvements #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
k0beLeenders
commented
Feb 20, 2025
•
k0beLeenders
commented
- started bank service file (one step closer to functional and class based sdk)
- moved bank utils to service file
- fixed various issues from the pnpm migration
- added support for oracle to bank
- verified oracle setup key logic
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
✅ Meticulous spotted zero visual differences across 197 screens tested: view results. Meticulous simulated ~4 hours of user flows but tested none of the executable lines edited in your PR. If your PR does not modify your frontend this is expected. If this is a new feature or Meticulous was recently introduced then Meticulous will generate tests to cover your code in the coming days1. 1. If you wish to increase coverage immediately you can do so by interacting with your feature on localhost. Expected differences? Click here. Last updated for commit 957ace2. This comment will update as new commits are pushed. |
k0beLeenders
changed the title
k0beLeenders
requested review from
borcherd
and removed request for
losman0s
k0beLeenders
force-pushed
the
develop
branch
from
7cb0e53 to
53b9494
Compare
k0beLeenders
force-pushed
the
feat/arena-improvements
branch
from
523e223 to
b14540f
Compare
k0beLeenders
changed the title
- started bank service file (one step closer to functional and class based sdk) - fixed various issues from the pnpm migration - added support for oracle to bank - verify oracle setup key logic (todo)
k0beLeenders
force-pushed
the
feat/arena-improvements
branch
from
267f469 to
957ace2
Compare
borcherd
reviewed
Feb 24, 2025
| @@ -25,7 +25,7 @@ export const PwaSignIn = ({ isLoading, isActiveLoading, setIsActiveLoading, setI | |||
| return ( | |||
| <> | |||
| <OnboardHeader | |||
| title={process.env.NEXT_PUBLIC_APP_ID === "marginfi-v2-ui" ? "# to marginfi" : "Enrter The Arena"} | |||
borcherd
approved these changes
Feb 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.