feat(mrgn-fe): actionbox revamp & pnl improvements to the arena #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
k0beLeenders
commented
Mar 3, 2025
•
k0beLeenders
commented
- big actionbox error revamp
- various aren updates to use the improved pnl calculation
- added possibility to easily hide and show lists categories in the lendbox - fixed deposit-swap cta in withdrawing
feat(mrgn-fe): error handling revamp & lots of improvements
|
✅ Meticulous spotted zero visual differences across 203 screens tested: view results. Meticulous simulated ~4 hours of user flows which tested 126/1167 of the executable lines edited in your PR1. 1. These 1041 untested lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost. Expected differences? Click here. Last updated for commit 96f669f. This comment will update as new commits are pushed. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
k0beLeenders
changed the title
chambaz
approved these changes
Mar 4, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.