Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update ktlint to 1.0.0 #94

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Update ktlint to 1.0.0 #94

merged 3 commits into from
Sep 10, 2023

Conversation

mrmans0n
Copy link
Owner

@mrmans0n mrmans0n commented Sep 9, 2023

Due to the reasons exposed in pinterest/ktlint#2044, this is not trivial - we need to rewrite the fixes manually or remove them altogether. Not being able to rely on the embedded kotlin compiler plugin for this is less than ideal, I wanted to stay away from ASTNode as much as possible :(

TODO:

  • Fix spotless version
  • Fix ViewModelInjection autofix
  • Fix PreviewPublic autofix

Due to the reasons exposed in pinterest/ktlint#2044, this is not trivial - we need to rewrite the fixes manually or remove them altogether. Not being able to rely on the embedded kotlin compiler plugin for this is less than ideal, I wanted to stay away from ASTNode as much as possible :(

TODO:
- [x] Fix spotless version
- [ ] Fix ViewModelInjection autofix
- [ ] Fix PreviewPublic autofix
@mrmans0n mrmans0n merged commit cfc1f87 into main Sep 10, 2023
@mrmans0n mrmans0n deleted the ktlint-1.0 branch September 10, 2023 10:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant