Some small updates so it still works fine :) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tivity to use RxJava2.
- fixed RxJava2 NPE - added location access request - updated some dependencies
|
Hey, thank you guys! I will check the pull requests and merge them to the repo :) |
diegotori
reviewed
Jul 24, 2018
| @@ -116,12 +124,12 @@ public void onFailure(int reason) { | |||
| * @return a {@link Single} observable that emits a null value for successful discovery, or | |||
| * throws an error | |||
| */ | |||
| public Single<Void> singleDiscoverPeers() { | |||
| public Single<Object> singleDiscoverPeers() { | |||
There was a problem hiding this comment.
I think we should convert this to Completable since that is the recommended way to represent Observable<Void> without having to ever return null.
Also, Single easily converts to Completable via toCompletable() method.
diegotori
reviewed
Jul 24, 2018
| @@ -220,7 +228,7 @@ public void onFailure(int reason) { | |||
| * @return a {@link Single} observable that emits the intent which indicated that p2p peers | |||
| * changed | |||
| */ | |||
| private Single<Intent> listenForNewPeers(Single<Void> voidSingle) { | |||
| private Single<Intent> listenForNewPeers(Single<Object> voidSingle) { | |||
There was a problem hiding this comment.
Might be affected by the above comment regarding converting this to a Completable. Perhaps it might make sense to convert this to an ObservableTransformer.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on sgarfinkel's RxJava2 updates (thanks for that!) I also added some minor fixes so the lib and app would still work fine as of today.