Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: replaces lodash.memoize with alternatives #61

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

sverweij
Copy link
Member

@sverweij sverweij commented Jul 13, 2024

Description

  • replaces lodash.memoize with straightforward native alternative
  • drive by: removes now unused lodash dependency
  • drive by: removes unused @typescript-eslint/parser devDependency
  • drive by: fixes typo in the check:all script in package.json

Motivation and Context

  • reduce maintenance
  • reduce bundle size

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij merged commit 4355996 into master Jul 13, 2024
2 checks passed
@sverweij sverweij deleted the refactor/replaces-lodash-memoize-with-alternative branch July 13, 2024 12:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant