Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: remove mismatch from flags when lcov < 2 #127

Merged
merged 1 commit into from
Oct 16, 2024
Merged

perf: remove mismatch from flags when lcov < 2 #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion cmake/test/Coverage.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ elseif(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU")
endif()

set(CODE_COVERAGE_LCOV_EXTRA_FLAGS
"--ignore-errors=gcov,mismatch"
"--ignore-errors=gcov,mismatch,mismatch"
CACHE STRING "Extra command line flags to pass to lcov.")

set(CODE_COVERAGE_GCOVR_EXTRA_FLAGS
Expand Down Expand Up @@ -262,6 +262,31 @@ if(CODE_COVERAGE AND NOT CODE_COVERAGE_INITIALIZED)
if(LCOV_PATH)
add_custom_target(ccov-clean COMMAND ${LCOV_PATH} --directory
${CMAKE_BINARY_DIR} --zerocounters)
execute_process(
COMMAND "${LCOV_PATH}" --version
RESULT_VARIABLE _result
OUTPUT_VARIABLE _output
OUTPUT_STRIP_TRAILING_WHITESPACE)
message(STATUS "_output: ${_output}")
if(_result EQUAL 0 AND _output MATCHES " LCOV version ([0-9]+)")
set(LCOV_MAJOR_VERSION "${CMAKE_MATCH_1}")
if(LCOV_MAJOR_VERSION VERSION_LESS "2"
AND CODE_COVERAGE_LCOV_EXTRA_FLAGS MATCHES "mismatch")
message(
WARNING
"Does not support mismatch by lcov less 2 and remove params from ${CODE_COVERAGE_LCOV_EXTRA_FLAGS}..."
)
string(REPLACE [[mismatch]] "" CODE_COVERAGE_LCOV_EXTRA_FLAGS
${CODE_COVERAGE_LCOV_EXTRA_FLAGS})
set(CODE_COVERAGE_LCOV_EXTRA_FLAGS
"${CODE_COVERAGE_LCOV_EXTRA_FLAGS}"
CACHE STRING "Extra flags to pass to lcov" FORCE)
message(
STATUS
"Final CODE_COVERAGE_LCOV_EXTRA_FLAGS: ${CODE_COVERAGE_LCOV_EXTRA_FLAGS}"
)
endif()
endif()
endif()

elseif(CMAKE_C_COMPILER_ID MATCHES [[MSVC]] OR CMAKE_CXX_COMPILER_ID MATCHES
Expand Down
Loading