Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop python2 support #519

Merged
merged 12 commits into from
May 21, 2023
Merged

Drop python2 support #519

merged 12 commits into from
May 21, 2023

Conversation

sblondon
Copy link
Contributor

The PR removes python2 references and cases.
tox command is green on cpython3.9 (py39-c and py39-pure) on my local machine.

Close #518

They were used to hide differences (name or behaviour) between python2 and 3. So they are not useful anymore due to the removal of python2 support.
@sblondon sblondon changed the title Drop python2 Drop python2 support Sep 11, 2022
@sblondon sblondon changed the title Drop python2 support Drop python2 support (implementation) Sep 11, 2022
datetime.timezone.utc exists since python 3.2
@methane methane changed the title Drop python2 support (implementation) Drop python2 support Dec 6, 2022
@sblondon
Copy link
Contributor Author

sblondon commented Dec 9, 2022

The last commit should fix the black step error in the Github CI (https://github.com/msgpack/msgpack-python/actions/runs/3630468029/jobs/6156022655).

However, when I run black . on my system, there are several other changes (a lot of a**b modified to a ** b). They are not added to the commit in order to limit the changes. I can add them if you want.

@ThomasWaldmann
Copy link
Contributor

ThomasWaldmann commented Dec 9, 2022

@sblondon it might depend on the black version used.

At @borgbackup, we have a version-fixed requirement in requirements.d/codestyle.txt so everybody uses exactly the same version.

At @msgpack there is also such a definition in requirements.txt, did you use it?

@sblondon
Copy link
Contributor Author

sblondon commented Dec 9, 2022

At @msgpack there is also such a definition in requirements.txt, did you use it?

No, I runned the black which is installed on the system, not the version defined in requirements.txt file. So the differences generated by black are not useful here: all checks (including black) are green on Github CI.

@methane methane added this to the 1.1 milestone May 21, 2023
@methane methane merged commit feec062 into msgpack:main May 21, 2023
@sblondon sblondon deleted the drop-python2 branch May 22, 2023 21:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 2 support
3 participants