Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

move project metadata to pyproject.toml #555

Merged
merged 2 commits into from
Sep 5, 2023
Merged

move project metadata to pyproject.toml #555

merged 2 commits into from
Sep 5, 2023

Conversation

ThomasWaldmann
Copy link
Contributor

@ThomasWaldmann ThomasWaldmann commented Aug 31, 2023

also: replace flake8 by ruff.

@ThomasWaldmann
Copy link
Contributor Author

I converted the metadata from setup.cfg "as is" to pyproject.toml.
I also added some stuff that is currently commented out as a suggestion, these were not present in setup.cfg.

Maybe interesting for another PR: https://stackoverflow.com/questions/74608905/single-source-of-truth-for-python-project-version-in-presence-of-pyproject-toml

@ThomasWaldmann
Copy link
Contributor Author

Hmm, the black section targets py37 (which is not within the supported python versions) - shall that be py38?

@ThomasWaldmann ThomasWaldmann marked this pull request as ready for review August 31, 2023 10:55
also: clean up some stuff it complained about.
@ThomasWaldmann ThomasWaldmann mentioned this pull request Sep 4, 2023
@methane methane changed the title move project metadata to pyproject.toml, fixes #540 move project metadata to pyproject.toml Sep 5, 2023
@methane methane linked an issue Sep 5, 2023 that may be closed by this pull request
2 tasks
@methane methane removed a link to an issue Sep 5, 2023
2 tasks
@methane methane merged commit 423c6df into msgpack:main Sep 5, 2023
@ThomasWaldmann ThomasWaldmann deleted the metadata-pep621 branch September 5, 2023 10:51
@ThomasWaldmann
Copy link
Contributor Author

@methane Maybe you missed my comment about the suggestions / commented stuff in pyproject.toml - maybe just look through it and remove the comment chars to activate all suggestions you like to have.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants