-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(gaussian)!: Redesign API #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 97.95% 91.91% -6.05%
==========================================
Files 5 6 +1
Lines 294 470 +176
==========================================
+ Hits 288 432 +144
- Misses 6 38 +32
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tasshi-me
force-pushed
the
feature/redesign-api
branch
from
January 12, 2021 15:07
27c7ebd
to
f1a41a3
Compare
tasshi-me
force-pushed
the
feature/redesign-api
branch
from
January 12, 2021 18:37
8776ad9
to
6c663fe
Compare
tasshi-me
force-pushed
the
feature/redesign-api
branch
from
February 15, 2021 11:49
ed272d8
to
6c663fe
Compare
tasshi-me
changed the title
BREAKING(gaussian): Redesign API
feat(gaussian)!: Redesign API
Aug 19, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesigns
gaussian
module following Rust API Guideline [en, ja].resolves TASSH-1
Checklist
Gaussian
structgaussian
module withGaussian
structgaussian::{val, fit}
Checklist (API Guideline)
as_
,to_
,into_
(C-CONV)?
in example (C-QUESTION-MARK)Debug
for all public types (C-DEBUG)