Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(gaussian)!: Redesign API #15

Merged
merged 15 commits into from
Aug 19, 2022
Merged

feat(gaussian)!: Redesign API #15

merged 15 commits into from
Aug 19, 2022

Conversation

tasshi-me
Copy link
Owner

@tasshi-me tasshi-me commented Jan 10, 2021

This PR redesigns gaussian module following Rust API Guideline [en, ja].

resolves TASSH-1

Checklist

  • create Gaussian struct
  • organiza functions under gaussian module with Gaussian struct
  • depricate gaussian::{val, fit}
  • documentation

Checklist (API Guideline)

  • as_, to_, into_ (C-CONV)
  • Getter (C-GETTER)
  • implement standard convert traits (C-CONV-TRAITS)
  • serde (C-SERDE)
  • use ? in example (C-QUESTION-MARK)
  • Link all the things (C-LINK)
  • publish intermediates (C-INTERMEDIATE)
  • generic float type arguments (C-GENERIC)
  • impl Debug for all public types (C-DEBUG)
  • re-export public dependencies (C-REEXPORT)

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #15 (1f23247) into main (92d5ded) will decrease coverage by 6.04%.
The diff coverage is 89.26%.

❗ Current head 1f23247 differs from pull request most recent head cf65408. Consider uploading reports for the commit cf65408 to get more accurate results

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   97.95%   91.91%   -6.05%     
==========================================
  Files           5        6       +1     
  Lines         294      470     +176     
==========================================
+ Hits          288      432     +144     
- Misses          6       38      +32     
Impacted Files Coverage Δ
src/gaussian/gaussian.rs 79.88% <79.88%> (ø)
src/gaussian/operations.rs 100.00% <100.00%> (ø)
src/lib.rs 100.00% <100.00%> (ø)
src/linalg.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tasshi-me tasshi-me force-pushed the feature/redesign-api branch from 27c7ebd to f1a41a3 Compare January 12, 2021 15:07
@tasshi-me tasshi-me force-pushed the feature/redesign-api branch from 8776ad9 to 6c663fe Compare January 12, 2021 18:37
Repository owner deleted a comment from linear bot Feb 4, 2021
@tasshi-me tasshi-me force-pushed the feature/redesign-api branch from ed272d8 to 6c663fe Compare February 15, 2021 11:49
@tasshi-me tasshi-me self-assigned this Mar 10, 2021
@tasshi-me tasshi-me changed the title BREAKING(gaussian): Redesign API feat(gaussian)!: Redesign API Aug 19, 2022
@tasshi-me tasshi-me changed the base branch from develop to main August 19, 2022 17:20
@tasshi-me tasshi-me merged commit 14c9340 into main Aug 19, 2022
@tasshi-me tasshi-me deleted the feature/redesign-api branch August 19, 2022 18:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant