Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Module:ppflagfixer #43

Merged
merged 16 commits into from
Jul 25, 2024
Merged

Module:ppflagfixer #43

merged 16 commits into from
Jul 25, 2024

Conversation

huyu335
Copy link
Collaborator

@huyu335 huyu335 commented Feb 27, 2024

PR checklist

Closes #42

  • Feature branch is named: feature/<module_name>, or if there is a subcommand feature/<module_name>/<module_subcommand>. This is important for automated documentation.
  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@huyu335 huyu335 marked this pull request as draft February 27, 2024 04:48
@huyu335 huyu335 marked this pull request as ready for review February 27, 2024 15:20
@huyu335 huyu335 requested a review from a team as a code owner April 3, 2024 21:34
Copy link
Collaborator

@buehlere buehlere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@huyu335 huyu335 merged commit eaabe46 into develop Jul 25, 2024
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants