Fixed data bits issue #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t 8 (See Alpha Sign Communications Protocol, Section 4.4, Protocol version comparison, on page 8)
|
Thanks for the details and the fix. Please address my comments before I merge. |
|
Fixed and fixed. Sorry about that dict thing- that was for some testing I was doing, and I didn't realize github automatically updated the pull requests with my commits. |
|
If I merge this, the commit history will contain the unwanted commits as well, unfortunately. Can you rebase and remove the undesired ones? |
|
Rebased |
|
LGTM. Thanks! |
msparks
added a commit
that referenced
this pull request
Dec 5, 2012
Specify seven data bits in the serial interface. pyserial defaults to 8, but the Alpha protocol calls for 7.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I downloaded this module to interact with my Alpha Big Dot sign. However, none of the commands worked. When I looked into the official documentation, it says that a 2 stop bit, even parity packet calls for 7 data bits per byte. serial.Serial defaults to 8. Fixed.