Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat (in-cluster): [ingress-controller] update nginx to v1.11.3 #102

Merged
merged 19 commits into from
Nov 20, 2024
Merged

feat (in-cluster): [ingress-controller] update nginx to v1.11.3 #102

merged 19 commits into from
Nov 20, 2024

Conversation

ferantivero
Copy link
Contributor

@ferantivero ferantivero commented Nov 14, 2024 •
edited
Loading

WHY

Moving to k8s 1.30 enables the possibility of upgrading to newer nginx versions

What Changed?

Test

image

image

image

image image image image

@ferantivero
upgrade old reference to 1.9.0 to 1.11.3
b78c8a5
@ferantivero
snippet annotation no longer allowed in 1.11.3 by default
433307a
@ferantivero
be explicit about enabling metrics since it is being scraped
5f00071
@ferantivero
ensure the image is the expected one
afc8c9d
@ferantivero
nginx no longer requires escalation priviledges
5555303
@ferantivero
nginx requires being able to read the root filesystem
9a8209f
@ferantivero
ensure nginx is not runnning as root
d21c5d6
@ferantivero
add seccomp profile type
4800cb1
@ferantivero
inlcude the admission validation service port
e6db57a
@ferantivero
Service account for admission now includes the token automount in true
cdd1dd4
@ferantivero
update certgen image version
127c989
@ferantivero
update sec context to be aligned with new nginx job
e377c09
@ferantivero
update certgen image version for patch container
06990bf
@ferantivero
update sec context to be aligned with new nginx job patch and resinst…
83991aa 
…ate fsgroup for create
@ferantivero
update deployment docs
ddf86a8
@ferantivero
bug fix: remove sha256 from acr image imports
cdbbf95
@ferantivero
bug fix: indent nginx manifest file properly and remove sha256 image …
71c7ac0 
…names
@ferantivero ferantivero marked this pull request as ready for review November 15, 2024 18:34
johndowns
johndowns approved these changes Nov 17, 2024
View reviewed changes
Copy link

@johndowns johndowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ferantivero
Copy link
Contributor Author

#sign-off

@johndowns johndowns merged commit d4e3fc1 into mspnp:main Nov 20, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@johndowns johndowns johndowns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferantivero @johndowns