Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

AKS Baseline regulated - Bug fixes - Ingress-controller certgen image regression issue - CA mismatch - osm certificate rotation #59

Merged
merged 2 commits into from
Mar 29, 2022
Merged

AKS Baseline regulated - Bug fixes - Ingress-controller certgen image regression issue - CA mismatch - osm certificate rotation #59

merged 2 commits into from
Mar 29, 2022

Conversation

magrande
Copy link
Contributor

No description provided.

@magrande magrande requested a review from ckittel March 28, 2022 17:05
ckittel
ckittel approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this one item, LGTM 🚀 (I know you're going to hold off for ~30 hours to make sure the cert rotates fine.)

@magrande
Copy link
Contributor Author

Tests went pretty well ! Merging !

@magrande magrande merged commit 6101f6e into main Mar 29, 2022
@magrande magrande deleted the ingress-bugs branch March 29, 2022 16:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ckittel ckittel ckittel approved these changes

Assignees

@magrande magrande

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magrande @ckittel