Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

AKS Baseline regultated RA - convert subscription deployment to Bicep #62

Merged
merged 17 commits into from
Apr 22, 2022
Merged

AKS Baseline regultated RA - convert subscription deployment to Bicep #62

merged 17 commits into from
Apr 22, 2022

Conversation

magrande
Copy link
Contributor

@magrande magrande commented Apr 12, 2022 •
edited
Loading

@ckittel Tested successfully up to the creation of the cluster and flux deployment

@magrande magrande requested a review from ckittel April 12, 2022 23:02
@magrande magrande changed the title Bicep subscription AKS Baseline regultated RA - convert subscription deployment to Bicep Apr 12, 2022
@magrande magrande self-assigned this Apr 12, 2022
ckittel
ckittel requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mariano! Feedback here in the PR review. You'll see a couple of patterns. This is looking on track, nice.

magrande and others added 4 commits April 19, 2022 14:06
@magrande
Addressing comments
4a41b57
@magrande @ckittel
Update modules/resourceGroupPolicyAssignment.bicep
568173e 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@magrande @ckittel
Update modules/resourceGroupPolicyAssignment.bicep
3ce8807 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@magrande @ckittel
Update modules/resourceGroupPolicyAssignment.bicep
29b2d7f 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
ckittel
ckittel reviewed Apr 19, 2022
View reviewed changes
ckittel
ckittel reviewed Apr 19, 2022
View reviewed changes
ckittel
ckittel reviewed Apr 19, 2022
View reviewed changes
magrande and others added 4 commits April 19, 2022 16:42
@magrande @ckittel
Update subscription.bicep
499a08b 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@magrande @ckittel
Update subscription.bicep
1447e4a 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@magrande
Some more usage of existing resources
7e3518d
@magrande
refactored custom-builtin policy assignments
e2b6630
ckittel
ckittel requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the last batch, almost there!

ckittel
ckittel reviewed Apr 22, 2022
View reviewed changes
ckittel
ckittel approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready to merge if you've completed your testing. 🥳

@magrande magrande merged commit 6b12ce6 into main Apr 22, 2022
@magrande magrande deleted the bicep-subscription branch April 22, 2022 17:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ckittel ckittel ckittel approved these changes

Assignees

@magrande magrande

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magrande @ckittel