AKS Baseline regulated - Bicep migration - Networking files #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckittel
reviewed
Apr 29, 2022
related: #596248
ckittel
requested changes
Sep 2, 2022
There was a problem hiding this comment.
@ferantivero - I was not able to get through the whole review before I had to leave for my PTO today. I got all of the non-bicep files reviewed and finished hub-region.v0.bicep - When I'm back in the office (6-Sep), I plan on proceeding with the rest of the .bicep files. If you wanted to review what I have here so far, that would be cool. There are a couple of things you'd forward-apply to .v1 and .v2
ferantivero
force-pushed
the
bicep-networking
branch
from
63050ef to
8c15583
Compare
ckittel
requested changes
Sep 6, 2022
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
ferantivero
force-pushed
the
bicep-networking
branch
from
7ef46d1 to
c94e849
Compare
ckittel
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
I think this covers it all now, @ferantivero - I resolved all the feedback. Once you're done with your testing cycle, feel free to merge if good to go.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing: #596248
WHY
we wanted to migrated all ARM json templated for networking to bicep in aks regulated baseline.
WHAT Changed?
HOW to Test?
you clone the repo, and it is possible to deploy hub and spoke networking Azure resources for regulated using Bicep templates.