generated from mspnp/aks-baseline
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat (workload identity): [aks-ingress] migrate pod to workload identity #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdc67e6
to
62c1b36
Compare
add oidcIssuerProfile add federated identity credentials
62c1b36
to
afda4db
Compare
afda4db
to
b4c7112
Compare
b4c7112
to
1129d95
Compare
ckittel
requested changes
Dec 6, 2022
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
ckittel
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great. I do have one question here... it's optional to change, and figured I'd let you decide.
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #24723
WHY?
we do want to move all our aks baseline from aad pod identity manually installed or via add-ons to workload identity.
WHAT changed?
HOW to test?
as a user you can now clone the aks regulated baseline repository, follow the instructions and the cluster stamp v2 will create federated credentials identity subject to the nginx ingress controller service account and enable the workload identity add on in the aks regulated cluster.
you can deploy the cluster end to end and validate it is working as expected.