Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

#84 Hide development folder's panel from New and edit schedule pages #92

Merged
merged 3 commits into from
Aug 29, 2022
Merged

#84 Hide development folder's panel from New and edit schedule pages #92

merged 3 commits into from
Aug 29, 2022

Conversation

sworup
Copy link
Contributor

@sworup sworup commented Aug 25, 2022 •
edited
Loading

Fixes #84

Test

  • Create a develop folder. It could be Develop the check is case insensitive.
  • Move or create panels in the develop folder.
  • Go to Excel Report email scheduler > Schedulers.
  • Create or edit a schedule
  • See the panels in develop folder are not in the list of available panels

@sworup sworup requested review from mark-prins and Mai21 August 25, 2022 08:03
@msupply-foundation msupply-foundation deleted a comment from omsupply-bot bot Aug 25, 2022
@sworup sworup linked an issue Aug 25, 2022 that may be closed by this pull request
Hide development folder's panel from New and edit schedule pages #84
Closed
mark-prins
mark-prins approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@mark-prins mark-prins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me - thanks @sworup

src/api/getPanels.api.ts Outdated Show resolved Hide resolved
@sworup sworup merged commit b0a8b0c into develop Aug 29, 2022
@sworup sworup deleted the #84-Hide-development-folder's-panel branch August 29, 2022 09:15
@sworup sworup mentioned this pull request Aug 29, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mark-prins mark-prins mark-prins approved these changes

@Mai21 Mai21 Awaiting requested review from Mai21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide development folder's panel from New and edit schedule pages
2 participants
@sworup @mark-prins