Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix undefined in fetching requisition #5213

Conversation

wmucheru
Copy link

Fixes #5212

Change summary

Fixes error that causes crashing when Use Suggested Quantities button is clicked

Testing

  • Go to Requisition page
  • Click Use Suggested Quantities

Related areas to think about

If there are any general areas of the codebase your changes might have side affects on, mention them here

Copy link
Contributor

@bijaySussol bijaySussol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wmucheru :

Look great to me
Thanks

@@ -241,11 +241,14 @@ const SupplierRequisition = ({
};
}) || [];

const { requisition } = data[0];
const { requisition } = data?.[0] || {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@sah-arjun sah-arjun self-requested a review May 30, 2023 09:41
Copy link
Contributor

@sah-arjun sah-arjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wmucheru looks good.
Going to build apk asap!

@sah-arjun sah-arjun merged commit 74f5221 into msupply-foundation:feature/macro-eyes May 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants