Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#5215 fixed alert issue for name duplicity check #5219

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

sah-arjun
Copy link
Contributor

Fixes #5215

Change summary

Mobile > In the vaccination module > Name duplicity check alert should be generated for new patient.
Check for local duplicity of patient when creating new.
If patient already exists with same lastName, firstName, and dateOfBirth then we need a confirmation modal.
Either we can cancel the duplicity or can create duplicate patient.

Testing

Steps to reproduce or otherwise test the changes of this PR:

  • Go to Vaccination, if not activated then active from desktop
  • Create a new patient
  • Enter all mandatory fields, the Save button will be enable to create new patient.
  • Save above patient.
  • Try to recreate the same patient having same firstName, lastName, and dateOfBirth as above
  • If above fields are matched then an confirmation alert Are you sure you want to duplicate this patient? A patient with name: {0} and date of birth: {1} already exist. will be generated.
  • If you click Cancel then nothing will be saved and page return to first tab of vaccination page.
  • If you click OK then you are allowed to create a duplicate patient having same details as above.
  • After clicking OK, and entering all mandatory fields click Next button and process all step to create a patient and its related vaccination event.
  • In vaccination module a patient will be created successfully after vaccination.
  • After this test same process from Dispensing module too.

Related areas to think about

If there are any general areas of the codebase your changes might have side affects on, mention them here

sah-arjun added 2 commits June 2, 2023 15:34
#5215 fixed alert issue in duplicity of name at Vaccination module
@sah-arjun sah-arjun requested a review from anildahalsussol June 6, 2023 11:39
@anildahalsussol
Copy link
Contributor

@arjunSussol : Still getting the same issue as raised.

#5215 fixed undefined name id
@sah-arjun
Copy link
Contributor Author

@arjunSussol : Still getting the same issue as raised.

@anildahalsussol should be fixed by bd02957

Copy link
Contributor

@anildahalsussol anildahalsussol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No more issue but there is another policies issue which is already reported by @AnushaUp.
And as agreed: duplicity while editing is ignored.

@sah-arjun sah-arjun merged commit 36c2348 into develop Jun 12, 2023
@sah-arjun sah-arjun deleted the #5215-wrong-alert-for-existing-patient branch June 12, 2023 07:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants