Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show password button #5398

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Show password button #5398

merged 1 commit into from
Dec 26, 2023

Conversation

mark-prins
Copy link
Contributor

Fixes #5394

Change summary

Adds a button to toggle the password visibility. This applies to both the login and initialisation screens:

Screen.Recording.2023-12-15.at.11.38.47.AM.mov

init

Testing

Steps to reproduce or otherwise test the changes of this PR:

  • Check that init and login still work
  • And that you can show / hide the password

Related areas to think about

If there are any general areas of the codebase your changes might have side affects on, mention them here

@sah-arjun sah-arjun self-requested a review December 26, 2023 09:29
Copy link
Contributor

@sah-arjun sah-arjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sah-arjun sah-arjun merged commit 7f4fdd3 into develop Dec 26, 2023
@sah-arjun sah-arjun deleted the 5394-show-password branch December 26, 2023 09:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants