Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#213 Update msupply-dashboard-app plugin with excel-report-email-scheduler plugin #214

Conversation

sworup
Copy link
Contributor

@sworup sworup commented Sep 15, 2022

Fixes #213

Description

  • mSupply dashboard app plugin has had a major version upgrade. The name itself is too generic and has been replaced with a name that explains the functionality of the plugin better.
  • We need to replace the resources of the plugins and replace msupply-dashboard-app plugin with excel-report-email-scheduler plugin in the Dashboard installer.

The plugin repo is: https://github.com/openmsupply/excel-report-email-scheduler
The latest release of the plugin can be found here: https://github.com/openmsupply/excel-report-email-scheduler/releases

Checklist:

  • On fresh install the excel-report-email-scheduler should be available to activate by default.
  • msupply-dashboard-app should be deprecated.
  • The msupply.db and template.slsx files have been incorporated into the installer directory domain so we have make sure the client backs up these files and replaces them.
    • One small but breaking change is in msupply.db's ReportContent table, the lookback field is now of type text instead of number. We have to make that change if we are backing up older db and replacing.

Documentation:

  • Requires a change to the documentation.
  • Documentation has been updated.

Tests:

  • Setup exe creates properly
  • The exe installs properly
  • The deprecated mSupply dashboard app plugin is not in the available plugins list
  • The plugin excel-report-email-scheduler shows up in the list of available plugins list
  • The plugin excel-report-email-scheduler activates as expected
  • The path to mSupply.db and template.xlsx are properly accepted by the installed plugin. You would know if there is no 'No datasource found' error when you open the plugin pages.
  • The plugin configuration form shows up as menu item and is submittable without problem
  • Admin user can create ReportGroups and schedules
  • Test send button of Scheduler page send plugins
  • Tests have been added.
  • All new and existing tests passed.

@omsupply-bot omsupply-bot bot added Enhancement New feature or request Priority: High labels Sep 15, 2022
@sworup sworup requested a review from mark-prins September 15, 2022 06:24
Copy link
Contributor

@mark-prins mark-prins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! thanks Sworup

@sworup sworup merged commit 97eb515 into master Sep 20, 2022
@sworup sworup deleted the #213-Update-msupply-dashboard-app-plugin-with-excel-report-email-scheduler-plugin branch September 20, 2022 07:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Enhancement New feature or request Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update msupply-dashboard-app plugin with excel-report-email-scheduler plugin
2 participants