docs: url without pathName on server listen #266
Conversation
|
@reslear is attempting to deploy a commit to the MSW Team on Vercel. A member of the Team first needs to authorize it. |
| } | ||
|
|
||
| // Skip non-server API requests | ||
| if (url.origin !== process.env.API_URL) { |
There was a problem hiding this comment.
I would remove this from the example, it's too specific. It relies on the user having the API_URL env variable and even being familiar with the concept of env variables. Let's keep the example to the necessary minimum 👍
There was a problem hiding this comment.
I just saw your example with env variable
and thought it was appropriateI have other requests running on the server that don't need to be mocked, i believe that if this example had been and indexed by search, I wouldn't have spent 15 minutes looking for how to do it in issue :)
what if we moved it to faq with our h2 title like - "How to control or manage requests to different domains" ?
request.urlis string notURLconstructor :)I also added a useful example (like mswjs/msw#1636 (reply in thread)) so you don't have to search for it