Feat: Allow configuration using environment variables #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We actually deployed trello-burndown in AWS with postgresql in RDS, configuration is retrieved from AWS parameter store using chamber and it works like a charm. |
dlovera
changed the title
|
Thanks for your contribution! I'll test, build and publish the changes soon! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I use the dockerized version of your trello-burndown (which is great by the way!) and thought it would be nice to use environment variables for configuration instead of config file (so I don't bother creating volumes) Using environment variables also allows to use a remote database (I use postgresql instead of sqlite)
Hope this can help.