Fix bug for Scalable-Broadcast #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the current Scalable-Broadcast demo (https://rtcmulticonnection.herokuapp.com/demos/Scalable-Broadcast.html) watchers on at least chrome and firefox cannot open a stream. This is because the browser tries to set the local answer sdp in a stable state. The solution is to not negotiate a new state when the state is stable.
|
@Periodic1911 👍 Thanks a lot for the fix. I can confirm that the fix allows streams to be hosted on Firefox (v74/Linux). I also tested on Chromium (v80.0.3987.87/Linux) and Chrome (Version 80.0.3987.149/Linux). These worked before (for me) and still do after the fix. @muaz-khan Is there any reason not to merge the PR? |
|
|
rajgoel
added a commit
to rajgoel/reveal.js-plugins
that referenced
this pull request
Apr 2, 2020
|
Bumping this issue. Would be great to have this merged in. @muaz-khan |
|
@muaz-khan This change has some issues:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the current Scalable-Broadcast demo (https://rtcmulticonnection.herokuapp.com/demos/Scalable-Broadcast.html) watchers on at least chrome and firefox cannot open a stream. This is because the browser tries to set the local answer sdp in a stable state. The solution is to not negotiate a new state when the state is stable.