-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci: add static-checker #2781
base: master
Are you sure you want to change the base?
ci: add static-checker #2781
Conversation
**Description** This PR adds a static-checker pipeline as part of our workflows **Notes for Reviewers** N/A **[Signed commits](../CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin)** - [x] Yes, I signed my commits. Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
PR description is too short and seems to not fulfill PR template, please fill in |
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚠ golint failed (.)Found 617 lint suggestions; failing. Show Detail
|
⚠ goimports failed (.)
|
⚠ shadow failed (.)
|
⚠ gosec failed (.)
Show Detail
|
PR description is too short and seems to not fulfill PR template, please fill in |
⚠ errcheck failed (.)
|
⚠ staticcheck failed (.)
|
This is a good idea mudler... but it seems a bit overactive. Can we tune that at all before we set it loose? Edit: I think I'm blaming the static checker for the description / title actions, which I didn't realize were distinct at first. Guess that's just going to take some getting used to on my part, ha |
⚠ golint failed (.)Found 604 lint suggestions; failing. Show Detail
|
⚠ goimports failed (.)
|
⚠ shadow failed (.)
|
⚠ gosec failed (.)
Show Detail
|
⚠ errcheck failed (.)
|
⚠ staticcheck failed (.)
|
Uh oh! Could not analyze this PR, maybe it's too big? |
Yes definitely, I've been opening this PR to see what should be addressed, not going to enable it until the warnings/errors are fixed. Let's use this PR for reference |
Description
This PR adds a static-checker pipeline as part of our workflows.
Notes for Reviewers
It's good to assess the state of the code, plus trying to identifying shortcomings before entering the code
Signed commits