-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[material-ui][Select] Fix variant type #41405
Conversation
Netlify deploy previewhttps://deploy-preview-41405--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This looks good @sai6855! #41401 and #41356 are fixed. For #41410, we're missing the error on line 64 of this playground: ![]() If we don't fix that one, then I don't know how users will be able to wrap the Select component, which is a common use case. There's another error on line 73 for which I couldn't find a fix, but we can accept that one as a TS limitation. cc: @michaldudak |
636740c
to
f4ccdb4
Compare
@DiegoAndai #41410 is fixed now, i changed implementation by removing I hope i covered all possbile scenarios in tests, but let me know if you see anything missing. Also updated issues in PR description |
Thanks, @sai6855, great work managing all those issues. I think this is the best solution. I agree that the I would like to get @michaldudak's opinion on this before merging. Also, I'll leave a comment at #39137 to see if people involved in that PR have any opinions about this change. |
closes #41401
closes #41356
closes #41375
closes #41410