Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[material-ui][docs] Remove deleted page from the sidenav #41594

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Mar 21, 2024

This PR removes the now non-existing "Material Design 3 components" page from the list of pages. I'm assuming we'll want to cherry-pick this one into master as well?

A regression from #41544. Fix https://app.ahrefs.com/site-audit/3524616/114/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Cdepth%2Ccompliant%2CincomingAllLinks%2Corigin&filterId=91013c8aafad4fe1f7a0ad504eccad42&issueId=c64da643-d0f4-11e7-8ed1-001e67ed4656&sorting=-pageRating

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Mar 21, 2024
@danilo-leal danilo-leal self-assigned this Mar 21, 2024
@mui-bot
Copy link

mui-bot commented Mar 21, 2024

Netlify deploy preview

https://deploy-preview-41594--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2445337

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, yep we should add this to master too.

@danilo-leal danilo-leal merged commit 0102a95 into mui:next Mar 22, 2024
19 checks passed
@danilo-leal danilo-leal deleted the remove-deleted-md3-page branch March 22, 2024 15:12
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse labels Apr 1, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 1, 2024

we should add this to master too

Done in 807032d. #41736 (comment) would be nice to scale this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation package: material-ui Specific to @mui/material regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants