Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[website] Open Staff Engineer role for Pigment CSS #42531

Merged
merged 19 commits into from
Jun 17, 2024

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Jun 5, 2024

@mnajdova mnajdova added the website Pages that are not documentation-related, marketing-focused. label Jun 5, 2024
@mui-bot
Copy link

mui-bot commented Jun 5, 2024

Netlify deploy preview

https://deploy-preview-42531--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 102c1a8

@mnajdova mnajdova marked this pull request as ready for review June 5, 2024 08:51
@zannager zannager requested a review from danilo-leal June 5, 2024 09:52
The work you will be doing is somewhat unique and idiosyncratic. You probably have not had a similar role before.
- **In open-source, you're faced with a nonstop stream of bug reports and support requests**. That means you need to develop an intuition for when to ignore something, and when to dig in further.

## Who we're looking for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also be much simpler here! I removed the bold "titles" and just straight up added the required skills on Docs-infra role, as an example: https://mui.com/careers/react-engineer-docs-infra/#who-were-looking-for — that should be enough, I believe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we aim in consistency of how we present the roles? We have template for starting, although we may change something in a particular job ad, all other roles would still be created differently.

For example, I changed the writing around the products in https://github.com/mui/material-ui/pull/42189/files, when it gets approved, I will apply this on the template. I think this is the only way to keep it consistent (if that's our goal).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, definitely aim for consistency! We can keep updating the template as we see fit 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. More details look OK. And since it's more verbose, we need a bold part for the quick job post readers. So 👍 to keep this as is on my end.

Comment on lines 99 to 105
- **Avoid monolithic deliverables**.
You scope and stage your work into well-defined milestones to ship.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Avoid monolithic deliverables**.
You scope and stage your work into well-defined milestones to ship.

I'd cut this one — it seems like too much of a practical guideline. If we'd like to keep it, I'd probably change to something along the lines of "You have a great sense of project management" because that's what it essentially is about: iterating fast, incrementally, with clear milestones

Copy link
Member

@oliviertassinari oliviertassinari Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this in the job offer makes me feel a bit like it's helpful to differentiate Junior/Mid level to Senior. But if this role level is Staff, we need to emphasize on what sets Staff (and people on a growth trajectory to Staff) appart as we might see a lot of Senior level apply. So, agree, there could be an opportunity here.

Copy link
Member

@oliviertassinari oliviertassinari Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried this 🤷‍♂️:

  • Leadership skills. You will help build the community and collaborate with it. You will guide and mentor contributors, steering the community in the right direction.


We're looking for someone with strong core JavaScript skills. More important than specific technical skills though is that you're a strong problem solver who loves to learn. Details matter to you.

### Required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be more specific about, maybe, experience with bundlers and some of the concrete tasks we need for Pigment? I feel like the things included in "Expertise in the modern JavaScript ecosystem" are too broad.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, though, I don't have ideas on my end on how to do this. Maybe @brijeshb42 would have.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me prepare a statement and share internally in the channel first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expertise in the modern JavaScript ecosystem

This is the one and most important requirement in my opinion for this role. I am open to suggestions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to put in Rust, given Turbopack/SWC and now Rolldown are written in Rust.
Their core plugin authoring system will also be in Rust. The equivalent JS plugin authoring will support limited functionality.

Copy link
Member

@oliviertassinari oliviertassinari Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried this 🤷‍♂️:

  • Expertise in the modern JavaScript ecosystem. Pigment CSS is built on the shoulders of giants, you need to use technologies such as TypeScript, Node.js, Babel, Rust, or SWC.

mnajdova and others added 7 commits June 9, 2024 22:43
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari force-pushed the role/staff-pigment-css branch from 4cddb30 to fd4928d Compare June 9, 2024 20:43
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 9, 2024

Rebased on HEAD to get #42530.

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go on my end. Feel free to continue iterating 👍

Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova mnajdova force-pushed the role/staff-pigment-css branch from 1adf2e9 to 2a4642f Compare June 12, 2024 09:52
@mnajdova mnajdova requested a review from danilo-leal June 12, 2024 10:33
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny edit suggestions—looking great, thanks for bearing with all my comments! 🙏

mnajdova and others added 2 commits June 15, 2024 07:02
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova mnajdova added the needs cherry-pick The PR should be cherry-picked to master after merge label Jun 15, 2024
@mnajdova mnajdova merged commit 6f567cc into mui:next Jun 17, 2024
20 checks passed
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants