Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[material-ui] Replace useThemeProps with useDefaultProps #44193

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

siriwatknp
Copy link
Member

closes #44128

Several components still using useThemeProps instead of useDefaultProps. That's why using DefaultPropsProvider does not work for these components.

@siriwatknp siriwatknp added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material labels Oct 23, 2024
@siriwatknp siriwatknp requested a review from mnajdova October 23, 2024 04:58
@mui-bot
Copy link

mui-bot commented Oct 23, 2024

Netlify deploy preview

https://deploy-preview-44193--material-ui.netlify.app/

TextField: parsed: -0.24% 😍, gzip: -0.22% 😍
NativeSelect: parsed: -0.40% 😍, gzip: -0.26% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against e5c634c

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a conformance test for this? We already have one that tests using the ThemeProvider, we can add additional test for using only DefaultPropsProvider. What do you think?

@siriwatknp siriwatknp requested a review from mnajdova October 24, 2024 04:06
@siriwatknp
Copy link
Member Author

Should we add a conformance test for this? We already have one that tests using the ThemeProvider, we can add additional test for using only DefaultPropsProvider. What do you think?

Added.

@siriwatknp siriwatknp merged commit 27441af into mui:master Oct 30, 2024
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🐛 Something doesn't work package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values defined in DefaultPropsProvider are ignored for Select component
4 participants