-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[docs][material-ui] Fix crashing of DraggableDialog demo #44811
Conversation
Netlify deploy previewhttps://deploy-preview-44811--material-ui.netlify.app/ Bundle size report |
@aarongarciah do you have any insight on why |
@sai6855 it's probably related to the UMD build. @DiegoAndai pinned the UMD versions on the example being used in the The error is not the same though:
I'm clueless on why this started to fail now. |
Looking into it |
The reason is that after bumping React 19, we're trying to build the UMD files using React 19, which isn't supported. I'm working on a solution to rely on React 18 only for the UMD build process. |
Opened a PR to fix it: #44815 |
@sai6855 the fix has been merged, please re-run the CI |
f502a2a
to
8f39c8b
Compare
fixes #44810
Logic taken from #44747 applied to v5.x branch
working preview: https://deploy-preview-44811--material-ui.netlify.app/material-ui/react-dialog/#draggable-dialog