Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[tooltip] Warn instead of error when trigger is disabled #44846

Merged
merged 1 commit into from
Dec 24, 2024
Merged

[tooltip] Warn instead of error when trigger is disabled #44846

merged 1 commit into from
Dec 24, 2024

Conversation

yash49
Copy link
Contributor

@yash49 yash49 commented Dec 23, 2024

closes #40355

@yash49 yash49 mentioned this pull request Dec 23, 2024
Closed
@mui-bot
Copy link

mui-bot commented Dec 23, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44846--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 59e19ae

@aarongarciah aarongarciah added component: tooltip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Dec 24, 2024
@aarongarciah aarongarciah changed the title [material-ui][Tooltip] Downgrade disabled error to a warning [material-ui][Tooltip] Warn instead of error when trigger is disabled Dec 24, 2024
@aarongarciah aarongarciah removed the request for review from DiegoAndai December 24, 2024 10:15
@aarongarciah aarongarciah force-pushed the tooltip-downgrade-error-to-warning branch from d4e75b3 to 59e19ae Compare December 24, 2024 10:18
@aarongarciah aarongarciah merged commit 3570a80 into mui:master Dec 24, 2024
19 checks passed
@aarongarciah
Copy link
Member

Thanks @yash49!

@oliviertassinari oliviertassinari changed the title [material-ui][Tooltip] Warn instead of error when trigger is disabled [Tooltip] Warn instead of error when trigger is disabled Dec 29, 2024
@oliviertassinari oliviertassinari changed the title [Tooltip] Warn instead of error when trigger is disabled [tooltip] Warn instead of error when trigger is disabled Dec 29, 2024
@oliviertassinari oliviertassinari added enhancement This is not a bug, nor a new feature and removed package: material-ui Specific to @mui/material labels Dec 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@aarongarciah aarongarciah aarongarciah approved these changes

Assignees
No one assigned
Labels
component: tooltip This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tooltip] Downgrade disabled error to a warning
4 participants
@yash49 @mui-bot @aarongarciah @oliviertassinari