Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[core] Remove redundant screenshots #44877

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 28, 2024

From #44876, it seems that we can simplify the screenshots we take.

I also used the opportunity to

  • fix
SCR-20241228-tjzc
  • nest the side components under a components folder, out of simplicity and clarity for developers.

Before: 1356 screenshots https://app.argos-ci.com/mui/material-ui/builds/34643/127712735
After: 1325 screenshots https://app.argos-ci.com/mui/material-ui/builds/34644/127719269

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes test labels Dec 28, 2024
@mui-bot
Copy link

mui-bot commented Dec 28, 2024

Netlify deploy preview

https://deploy-preview-44877--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e0552e1

@oliviertassinari oliviertassinari force-pushed the remove-redundant-screenshot branch from ef5d05f to 770f4dc Compare December 28, 2024 22:22
@oliviertassinari oliviertassinari force-pushed the remove-redundant-screenshot branch from 770f4dc to e0552e1 Compare December 28, 2024 22:32
@zannager zannager requested a review from zanivan December 30, 2024 10:42
@siriwatknp siriwatknp merged commit 61c6d1a into mui:master Jan 13, 2025
22 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
core Infrastructure work going on behind the scenes test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants