[material-ui][CircularProgress] Improve indeterminate animation to be symmetric and smooth #44934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44934--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
DiegoAndai
changed the title
|
@zanivan may I ask you to review this one? |
zanivan
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Hey @yashdev16 this looks smooth! Thanks for the improvement 🚀
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #44915
Changes Made:
Updated the @Keyframes circular-rotate animation in CircularProgress.js:
Changed the stroke-dasharray value from 100px to 1px for the 100% keyframe.
Adjusted the stroke-dashoffset value to -126px for greater precision.
Before:
The animation shows an odd "jump" as the arc moves quickly and then stops suddenly between the 50% and 100% phases.
After:
The animation is smooth and symmetric, with the arc contracting back to 1px between the 50% and 100% phases.
Preview: https://deploy-preview-44934--material-ui.netlify.app/material-ui/react-progress/