-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[material-ui][TextareaAutosize] Temporarily disconnect ResizeObserver to avoid loop error (#44540) #45238
Conversation
Netlify deploy previewhttps://deploy-preview-45238--material-ui.netlify.app/ @material-ui/core: parsed: +0.06% , gzip: +0.03% Bundle size reportDetails of bundle changes (Toolpad) |
@DiegoAndai any idea what happened with argos? 🤔 |
@mj12albert I'll look into it, looks like a font-aliasing thing that we might've fixed in the up-to-date branches but not on this one |
@mj12albert most look like antialising (similar to #44527 (comment)), but others don't. Do any of these look like they might be related to this change?
|
I'm not sure but the deploy preview seems fine: https://deploy-preview-45238--material-ui.netlify.app/material-ui/react-text-field/ |
@mj12albert I updated |
The test failed in Firefox 123: https://app.circleci.com/pipelines/github/mui/material-ui/149359/workflows/cf08c9ee-9c46-4430-9950-8046bc010541/jobs/802934 In v6.x the tested FF version is 131, though 123 is still supported according to browserslistrc |
@mj12albert I simply increased it from 3 to 4 😅 do you agree with the approach? |
👍 I tested increasing the timeout and it seems |
This reverts commit 131ffbf.
Cherry-pick #44540
Cherry-pick #45351
Cherry-picking this as it fixes a regression, which is covered in LTS.