Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[pickers] Fix date and time merging to retain milliseconds #14173

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Aug 12, 2024

Fixes tests for some reason only failing with mui@material v6 seen in #14142.

  • The util had missing milliseconds retaining.
  • A test was incorrect and not testing anything. 🤷 🙈

@LukasTy LukasTy added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! labels Aug 12, 2024
@LukasTy LukasTy self-assigned this Aug 12, 2024
@mui-bot
Copy link

mui-bot commented Aug 12, 2024

Deploy preview: https://deploy-preview-14173--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 53abcac

@flaviendelangle
Copy link
Member

One test seems to be complaining
But other than that, the fix and the test changes make a lot of sense!

@LukasTy
Copy link
Member Author

LukasTy commented Aug 12, 2024

One test seems to be complaining
But other than that, the fix and the test changes make a lot of sense!

Yeah, it seems that the tests was relying on a "buggy" previous behavior, where milliseconds were ignored.
I've aligned the initial and expected values to avoid the error. 👍

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it!

@LukasTy LukasTy merged commit 51ec133 into mui:master Aug 12, 2024
18 checks passed
@LukasTy LukasTy deleted the fix-date-utils-date-time-merging branch August 12, 2024 15:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants