Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[docs] Remove TypeScript v3 outdated version mentions #14443

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Sep 1, 2024

MateriaL UI sets the minimum supported ts version to 4.7, so it's time to remove v3 mentions in docs.
Fixes #14239

@@ -122,6 +122,7 @@ By default, the Data Grid uses the Material UI `theme.palette.background.defaul

```tsx
import { createTheme } from '@mui/material/styles';
import type {} from "@mui/x-data-grid/themeAugmentation";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes #14115, though it is already mentioned here https://mui.com/x/react-data-grid/getting-started/#typescript

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For #14115, I don't think that this PR solves it, IMHO, #14115 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do this in a separate PR 👍

@oliviertassinari oliviertassinari changed the title [DataGrid][Docs]: Remove TypeScript v3 outdated version mentions [DataGrid][docs] Remove TypeScript v3 outdated version mentions Sep 1, 2024
@zannager zannager added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Sep 2, 2024
@romgrk romgrk enabled auto-merge (squash) September 2, 2024 15:51
auto-merge was automatically disabled September 3, 2024 05:30

Head branch was pushed to by a user without write access

@k-rajat19 k-rajat19 requested a review from romgrk September 3, 2024 06:41
@LukasTy LukasTy changed the title [DataGrid][docs] Remove TypeScript v3 outdated version mentions [docs] Remove TypeScript v3 outdated version mentions Sep 3, 2024
@LukasTy LukasTy removed the component: data grid This is the name of the generic UI component, not the React module! label Sep 3, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏

@LukasTy LukasTy enabled auto-merge (squash) September 3, 2024 07:51
@k-rajat19
Copy link
Contributor Author

hm...same picker test is failing again, it seems like #14457 missed something ?

@LukasTy
Copy link
Member

LukasTy commented Sep 3, 2024

hm...same picker test is failing again, it seems like #14457 missed something ?

This branch was just out of sync with upstream/master.
I synced it and it should be great now. 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Remove TypeScript v3 outdated version mentions
6 participants