Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[core] Move warning methods to @mui/x-internals #14528

Merged
merged 4 commits into from
Sep 9, 2024
Merged

[core] Move warning methods to @mui/x-internals #14528

merged 4 commits into from
Sep 9, 2024

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Sep 7, 2024 •
edited by oliviertassinari
Loading

these methods should be moved to x-internals.

Related to mui/base-ui#615

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Sep 7, 2024
@oliviertassinari oliviertassinari changed the title [x-internals]: Move warning methods to @mui/x-internals [core] Move warning methods to @mui/x-internals Sep 7, 2024
@LukasTy LukasTy added the CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 label Sep 9, 2024
LukasTy
LukasTy approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏
The changes look great. 👍
They impact commercial code, but I've checked that you have already signed the CLA. 👌

I have pushed an empty commit to trigger CI.
CircleCI sometimes fails to run pipelines on contributor PRs. 🙈 🤷

@mui-bot
Copy link

mui-bot commented Sep 9, 2024

Deploy preview: https://deploy-preview-14528--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 6bc6310

@LukasTy LukasTy merged commit dd98382 into mui:master Sep 9, 2024
18 checks passed
@k-rajat19 k-rajat19 deleted the warning branch September 9, 2024 10:59
@oliviertassinari oliviertassinari mentioned this pull request Sep 17, 2024
Merged
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request Sep 30, 2024
@k-rajat19 @LukasTy
[core] Move warning methods to @mui/x-internals (mui#14528)
38cbfcc 
Co-authored-by: Lukas <llukas.tyla@gmail.com>
@mbreadmachine mbreadmachine mentioned this pull request Oct 5, 2024
Closed
This was referenced Oct 5, 2024
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Oct 6, 2024
Closed
This was referenced Oct 25, 2024
Open
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k-rajat19 @mui-bot @LukasTy @oliviertassinari