Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DataGrid] Fix error when initializing aggregation with row spanning #14710

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Sep 23, 2024

Fixes #14691

The row spanning tries to pre-compute some spanned rows during the initialization phase, but the aggregation wraps the valueGetter with a function that tries to access an API method getRowId which is not yet binded to the apiRef, the error occurs.

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row spanning Related to the data grid Row spanning feature labels Sep 23, 2024
@mui-bot
Copy link

mui-bot commented Sep 23, 2024

Deploy preview: https://deploy-preview-14710--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 9af8f54

@MBilalShafi MBilalShafi requested a review from a team September 23, 2024 14:41
@MBilalShafi MBilalShafi marked this pull request as ready for review September 23, 2024 14:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row spanning Related to the data grid Row spanning feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row spanning breaks with aggregation when colum type is number and aggreation is sum/avg
3 participants