Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TreeView] Fix Cursor navigation interferes with browser shortcut keys #14798

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Oct 2, 2024

closes #14296

@sai6855 sai6855 marked this pull request as draft October 2, 2024 06:55
@sai6855 sai6855 added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! labels Oct 2, 2024
@mui-bot
Copy link

mui-bot commented Oct 2, 2024

Deploy preview: https://deploy-preview-14798--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c26f44e

@sai6855 sai6855 force-pushed the fix-treeview-control branch from 7648749 to b4336d7 Compare October 2, 2024 07:38
@@ -182,6 +182,9 @@ export const useTreeViewKeyboardNavigation: TreeViewPlugin<
// If the focused item is expanded, we move the focus to its first child
// If the focused item is collapsed and has children, we expand it
case (key === 'ArrowRight' && !isRtl) || (key === 'ArrowLeft' && isRtl): {
if (ctrlPressed) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In windows alt + ArrowLeft or ArrowRight is used to navigate to prev/ next pages, i've tested in windows, current version looks good in windows hence didn't added any windows specific logic

@sai6855 sai6855 marked this pull request as ready for review October 2, 2024 07:50
@sai6855 sai6855 requested a review from michelengelen October 2, 2024 08:14
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! LGTM! :shipit:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tree view] Cursor navigation interferes with browser shortcut keys
3 participants