-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[TreeView] Fix Cursor navigation interferes with browser shortcut keys #14798
Conversation
Deploy preview: https://deploy-preview-14798--material-ui-x.netlify.app/ |
7648749
to
b4336d7
Compare
@@ -182,6 +182,9 @@ export const useTreeViewKeyboardNavigation: TreeViewPlugin< | |||
// If the focused item is expanded, we move the focus to its first child | |||
// If the focused item is collapsed and has children, we expand it | |||
case (key === 'ArrowRight' && !isRtl) || (key === 'ArrowLeft' && isRtl): { | |||
if (ctrlPressed) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In windows alt + ArrowLeft or ArrowRight
is used to navigate to prev/ next pages, i've tested in windows, current version looks good in windows hence didn't added any windows specific logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! LGTM!
closes #14296