Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[code-infra] Update renovate config and add vitest group #14856

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas added the scope: code-infra Specific to the core-infra product label Oct 7, 2024
@JCQuintas JCQuintas requested a review from a team October 7, 2024 10:45
@JCQuintas JCQuintas self-assigned this Oct 7, 2024
@mui-bot
Copy link

mui-bot commented Oct 7, 2024

Deploy preview: https://deploy-preview-14856--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f23bbd2

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about adding

pnpm --package renovate dlx renovate-config-validator --strict 

to CI? perhaps in the test_static job?

@JCQuintas
Copy link
Member Author

pnpm --package renovate dlx renovate-config-validator --strict

Do you think it would be worth it to run it on every pr? 🤔

@JCQuintas JCQuintas merged commit 418615e into mui:master Oct 7, 2024
20 checks passed
@JCQuintas JCQuintas deleted the vitest-renovate-merge branch October 7, 2024 12:32
@Janpot
Copy link
Member

Janpot commented Oct 7, 2024

Do you think it would be worth it to run it on every pr? 🤔

Probably won't degrade overall CI time, but maybe it's too much, yeah...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants