Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[DataGrid] Avoid row spanning computation of outdated rows #14902

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[DataGrid] Avoid row spanning computation of outdated rows #14902

merged 1 commit into from
Oct 10, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Oct 9, 2024 •
edited
Loading

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row spanning Related to the data grid Row spanning feature labels Oct 9, 2024
@mui-bot
Copy link

mui-bot commented Oct 9, 2024

Deploy preview: https://deploy-preview-14902--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 841db4e

@MBilalShafi MBilalShafi marked this pull request as ready for review October 9, 2024 18:17
@MBilalShafi MBilalShafi requested a review from a team October 9, 2024 18:17
@MBilalShafi MBilalShafi changed the title [DataGrid] Fix row spanning computation of stale rows [DataGrid] Fix row spanning computation of outdated rows Oct 9, 2024
@MBilalShafi MBilalShafi changed the title [DataGrid] Fix row spanning computation of outdated rows [DataGrid] Avoid row spanning computation of outdated rows Oct 9, 2024
@MBilalShafi MBilalShafi merged commit 69dc394 into mui:master Oct 10, 2024
24 checks passed
@DMPatod DMPatod mentioned this pull request Nov 2, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Nov 5, 2024
Merged
This was referenced Nov 8, 2024
Open
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@arminmeh arminmeh arminmeh approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row spanning Related to the data grid Row spanning feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Row spanning refers to invalid index in computeRowSpanningState when table rows change
3 participants
@MBilalShafi @mui-bot @arminmeh