Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[DataGrid] fix: pagination has unexpected behavior using -1 for "All" rows per page #16485

Merged
merged 2 commits into from
Feb 7, 2025
Merged

[DataGrid] fix: pagination has unexpected behavior using -1 for "All" rows per page #16485

merged 2 commits into from
Feb 7, 2025

Conversation

nusr
Copy link
Contributor

@nusr nusr commented Feb 6, 2025

fix #16431
page

@nusr
[DataGrid] fix: pagination has unexpected behavior
0915e9a 
Signed-off-by: Steve Xu <stevexugc@gmail.com>
@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Feb 7, 2025
romgrk
romgrk approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@romgrk romgrk enabled auto-merge (squash) February 7, 2025 18:18
@mui-bot
Copy link

mui-bot commented Feb 7, 2025

Deploy preview: https://deploy-preview-16485--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 31f542f

@romgrk romgrk merged commit 5ed0b65 into mui:master Feb 7, 2025
18 checks passed
@michelengelen michelengelen added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Feb 20, 2025
@michelengelen michelengelen mentioned this pull request Feb 20, 2025
Open
@mui mui deleted a comment from github-actions bot Feb 20, 2025
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

michelengelen pushed a commit to michelengelen/mui-x that referenced this pull request Feb 20, 2025
@nusr @michelengelen
[DataGrid] fix: pagination has unexpected behavior using -1 for "All"…
6c79d07 
… rows per page (mui#16485)

Signed-off-by: Steve Xu <stevexugc@gmail.com>
Co-authored-by: Rom Grk <romgrk@users.noreply.github.com>
(cherry picked from commit 5ed0b65)
@michelengelen
Copy link
Member

manually created cherry pick: #16666

KenanYusuf pushed a commit that referenced this pull request Feb 20, 2025
@michelengelen @nusr
[DataGrid] Cherrypick of (#16485) (#16666)
4975600 
Co-authored-by: Steve Xu <stevexugc@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] pagination has unexpected behavior using -1 for "All" rows per page
4 participants
@nusr @mui-bot @michelengelen @romgrk